feat: [M3-10391] - Surface LKE Node Pool Version for LKE Enterprise Clusters - #12596
Merged
bnussman-akamai merged 21 commits intoJul 31, 2025
Merged
bnussman-akamai merged 21 commits into
bnussman-akamai merged 21 commits into
Conversation
bnussman-akamai
changed the title
bnussman-akamai
commented
Jul 29, 2025
bnussman-akamai
marked this pull request as ready for review
July 30, 2025 13:26
bnussman-akamai
requested review from
coliu-akamai and
harsh-akamai
and removed request for
a team
July 30, 2025 13:27
mjac0bs
approved these changes
Jul 30, 2025
mjac0bs
left a comment
mjac0bs
left a comment
Contributor
There was a problem hiding this comment.
Thank you!
confirmed:
- api-v4 types and jsdoc related to Node Pools look accurate
- CI passes
- for an LKE-E cluster node pool, the version is visible at the bottom of the table
- responsive design looks good
- for an LKE cluster node pool, no version is visible at the bottom of the table
- we can make this version visible without feature-flagging under postLa
🐛 :
- one regression with the Add Tags button (see comment)
- we need to switch the MSW 2.0 node pool handlers over to
v4betaendpoints exclusively as well; currently we've got an infinite loading spinner for the NP section
Approving pending the above changes are made because the rest of this LGTM.
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
harsh-akamai
approved these changes
Jul 31, 2025
harsh-akamai
left a comment
harsh-akamai
left a comment
Contributor
There was a problem hiding this comment.
✅ Verify api-v4 types and jsdoc related to Node Pools are accurate
✅ Verify CI passes
✅ Verify you can see the Node Pool version in an LKE-E cluster
✅ Verify there are no regressions for the standard LKE cluster
coliu-akamai
approved these changes
Jul 31, 2025
coliu-akamai
left a comment
coliu-akamai
left a comment
Contributor
There was a problem hiding this comment.
✅ api types
✅ ci checks
✅ LKE-E - node pool version (saw same issue as Harsh)
✅ LKE standard - no version, didn't see regressions
✅ MSW looks good/works (didn't see LKE-E version for MSW nodepools but nbd since it's MSW)
thanks @bnussman-akamai!
bnussman-akamai
added
Approved
Cloud Manager UI test results🔺 1 failing test on test run #10 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/linode-storage.spec.ts" |
|||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
/v4betarather than a hybrid v4/v4beta approach for node poolsk8s_versionof each node pool in the UIPreview 📷
How to test 🧪
Prerequisites
lke-enterprise-eapinternal customer tag neededLKE Enterprisefeature flag is enabledVerify theLKE Enterprise➡️postLasub-feature-flag is also enabledVerification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅